libinit: Implement ErrNoModulesFound#2501
Conversation
Codecov ReportBase: 73.66% // Head: 73.83% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2501 +/- ##
==========================================
+ Coverage 73.66% 73.83% +0.16%
==========================================
Files 405 405
Lines 41234 41228 -6
==========================================
+ Hits 30377 30441 +64
+ Misses 10857 10787 -70
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I think you could log errors in a more readable way, e.g. so if modules files are not present, it proceeds to find conf, In that case, you still print an error from not finding ko files. |
|
Things are about to get better in error handling. |
Lack of modules in a given directory should be distinguishable from a error loading a module. Ignore such errors and continue to the other module loaders. Signed-off-by: Morten Linderud <morten.linderud@mullvad.net>
f7625bd to
72f48de
Compare
|
Changed the implementation to implement |
While rewriting stuff in #2482 I apparently overlooked the fact that we'd abort if any the functions fail.
InstallModulesFromDiris always going to return an error unless there is/lib/modules/*.kowhich means we won't be looking at the other places.A quickfix is to just never return an error on module loading. Another option would be to make the error from
InstallModulesFromDirmore granular so we can differentiate between "we found no files in this directory" and "we failed to load modules from this directory".I'm unsure what people would prefer?