Fuzzing for grub related parsing#2535
Merged
Merged
Conversation
94a5762 to
c14d39c
Compare
Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
Contributor
Author
|
Fixed some of the parsing in pkg/boot/grub by adding some more checks in commit dc5191d. |
Codecov ReportBase: 72.40% // Head: 73.66% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2535 +/- ##
==========================================
+ Coverage 72.40% 73.66% +1.25%
==========================================
Files 324 405 +81
Lines 34764 41229 +6465
==========================================
+ Hits 25172 30372 +5200
- Misses 9592 10857 +1265
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
rminnich
approved these changes
Oct 29, 2022
Navidem
pushed a commit
to google/oss-fuzz
that referenced
this pull request
Nov 7, 2022
Following the addition of some fuzzing tests ([#1](u-root/u-root#2528), [#2](u-root/u-root#2535), [#3](u-root/u-root#2536)) in the u-root project and [preparations for this integration](u-root/u-root#2543). You can check out its [website](https://u-root.org/) for more info on the project. Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com> Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows the same concept as #2528 but for the parsing of grub config files.
The tests either check for panics when parsing "random" grub cfg files or it check if a round-trip (parsing,write-back, parsing) results in the same parsed object.
The last commit a7c5147 contains inputs that fail in these tests. Refer to #2528 on how to reproduce these.