[fbnetboot] Fix error in retry logic.#2557
Merged
Merged
Conversation
As discovered and reproduced in #2517 (comment) there is a bug in the retry logic which causes code to continue executing even if all attempts to fetch the file have failed. This leads to a nil pointer panic. This PR restructures the code to vanquish the bug. Fixes #2517 Signed-off-by: Avi <avibrender@gmail.com>
Codecov ReportBase: 73.67% // Head: 73.67% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2557 +/- ##
=======================================
Coverage 73.67% 73.67%
=======================================
Files 405 405
Lines 41282 41282
=======================================
Hits 30416 30416
Misses 10866 10866 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rminnich
approved these changes
Nov 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discovered and reproduced in #2517 (comment) there is a bug in the retry logic which causes code to continue executing even if all attempts to fetch the file have failed. This leads to a nil pointer panic.
This PR restructures the code to vanquish the bug.
Fixes #2517
Signed-off-by: Avi avibrender@gmail.com