Skip to content

update to go-tpm 0.9.0#2703

Merged
10000TB merged 2 commits into
u-root:mainfrom
chrisfenner:main
Jun 28, 2023
Merged

update to go-tpm 0.9.0#2703
10000TB merged 2 commits into
u-root:mainfrom
chrisfenner:main

Conversation

@chrisfenner
Copy link
Copy Markdown
Member

This change updates u-root to use https://github.com/google/go-tpm at the latest released version 0.9.0. This version introduces a new, more complete API for talking to a TPM 2.0 (which may be of interest to other u-root users that need to do things with the TPM that go-tpm couldn't support before), but the entire existing API surface is available at its new path legacy/tpm2. This change updates all existing tpm2 callers within u-root (pkg/securelaunch/tpm and pkg/tss) to continue using the legacy go-tpm API at the new legacy path.

@chrisfenner chrisfenner marked this pull request as ready for review June 23, 2023 06:50
@chrisfenner chrisfenner requested a review from rminnich June 23, 2023 06:50
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.14 ⚠️

Comparison is base (9dddf41) 75.52% compared to head (9d6e18a) 75.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2703      +/-   ##
==========================================
- Coverage   75.52%   75.38%   -0.14%     
==========================================
  Files         414      414              
  Lines       42231    42231              
==========================================
- Hits        31895    31837      -58     
- Misses      10336    10394      +58     
Impacted Files Coverage Δ
pkg/securelaunch/tpm/tpm.go 0.00% <ø> (ø)
pkg/tss/capabilities.go 0.00% <ø> (ø)
pkg/tss/nvram.go 0.00% <ø> (ø)
pkg/tss/pcr.go 0.00% <ø> (ø)
pkg/tss/tpm_linux.go 14.00% <ø> (ø)
pkg/tss/tss.go 3.93% <ø> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rminnich
Copy link
Copy Markdown
Member

please sign off, thanks.

@rminnich rminnich added the Awaiting author Waiting for new changes or feedback for author. label Jun 27, 2023
@10000TB 10000TB self-requested a review June 27, 2023 18:17
@10000TB
Copy link
Copy Markdown
Member

10000TB commented Jun 27, 2023

+1 -- run git commit --amend --signoff to sign off . Otherwise, looks good

Signed-off-by: Chris Fenner <cfenn@google.com>
@chrisfenner
Copy link
Copy Markdown
Member Author

Signed-off, thanks!

@10000TB 10000TB merged commit 70b0606 into u-root:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting author Waiting for new changes or feedback for author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants