Skip to content

pkg/pci: run BusReader tests in a VM#3499

Merged
rminnich merged 1 commit into
u-root:mainfrom
Lencerf:test/bus_reader
Jan 30, 2026
Merged

pkg/pci: run BusReader tests in a VM#3499
rminnich merged 1 commit into
u-root:mainfrom
Lencerf:test/bus_reader

Conversation

@Lencerf
Copy link
Copy Markdown
Contributor

@Lencerf Lencerf commented Jan 29, 2026

BusReader tests expect the DUT has a PCI bus, which is not always true in different CI environments

@Lencerf Lencerf marked this pull request as ready for review January 29, 2026 23:29
@Lencerf
pkg/pci: run BusReader tests in a VM
6defa56 
BusReader tests expect the DUT has a PCI bus, which is not always true
in different CI environments.

Signed-off-by: Changyuan Lyu <changyuanl@google.com>
@Lencerf
Copy link
Copy Markdown
Contributor Author

Lencerf commented Jan 29, 2026 

    devices.go:275: vm: [20.0166s] === RUN   TestVM
    devices.go:275: vm: [20.1537s]     qemu.go:665: Skipping QEMU test as VMTEST_QEMU is not set
    devices.go:275: vm: [20.1971s] --- SKIP: TestVM (0.18s)
    devices.go:275: vm: [20.2892s] === RUN   TestNewBusReaderNoGlob
    devices.go:275: vm: [20.3897s] --- PASS: TestNewBusReaderNoGlob (0.18s)
    devices.go:275: vm: [20.4066s] === RUN   TestBusReader
    devices.go:275: vm: [20.6270s] --- PASS: TestBusReader (0.23s)
    devices.go:275: vm: [20.6352s] === RUN   TestBusReadConfig
    devices.go:275: vm: [20.6712s] --- PASS: TestBusReadConfig (0.03s)

=== RUN   TestNewBusReaderNoGlob
    skip.go:19: Skipping test -- must be run inside vmtest VM
--- SKIP: TestNewBusReaderNoGlob (0.00s)
=== RUN   TestBusReader
    skip.go:19: Skipping test -- must be run inside vmtest VM
--- SKIP: TestBusReader (0.00s)
=== RUN   TestBusReadConfig
    skip.go:19: Skipping test -- must be run inside vmtest VM
--- SKIP: TestBusReadConfig (0.00s)

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 29, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.87%. Comparing base (83d33d3) to head (6defa56).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3499      +/-   ##
==========================================
+ Coverage   55.00%   61.87%   +6.86%     
==========================================
  Files         533      638     +105     
  Lines       35918    43150    +7232     
==========================================
+ Hits        19755    26697    +6942     
- Misses      16163    16453     +290
Flag Coverage Δ
.-amd64 90.90% <ø> (?)
cmds/...-amd64 51.16% <ø> (-0.02%) ⬇️
integration/generic-tests/...-amd64 30.94% <ø> (?)
integration/generic-tests/...-arm 33.06% <ø> (?)
integration/generic-tests/...-arm64 30.12% <ø> (?)
integration/gotests/...-amd64 62.37% <ø> (ø)
integration/gotests/...-arm 62.91% <ø> (?)
integration/gotests/...-arm64 63.12% <ø> (?)
pkg/...-amd64 60.36% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
everything 67.04% <ø> (+7.04%) ⬆️
cmds/exp 32.84% <ø> (+0.41%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

rminnich
rminnich approved these changes Jan 30, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@rminnich rminnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@rminnich rminnich merged commit ee107bf into u-root:main Jan 30, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rminnich rminnich rminnich approved these changes

Assignees

@rminnich rminnich

@hugelgupf hugelgupf

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lencerf @rminnich @hugelgupf