Skip to content

fix(turbopack): add @ to clean_separators to avoid url decode #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fireairforce merged 1 commit into from
Dec 23, 2025
Merged

fix(turbopack): add @ to clean_separators to avoid url decode #84

fireairforce merged 1 commit into from
Dec 23, 2025
+2 −2

Conversation

@fireairforce
Copy link

@fireairforce fireairforce commented Dec 23, 2025

Before:

image

After:

image

@gemini-code-assist
Copy link

gemini-code-assist bot commented Dec 23, 2025

Summary of Changes

Hello @fireairforce, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a URL decoding anomaly within Turbopack by modifying how separator characters are handled. By explicitly including the @ symbol in the regular expressions used for cleaning strings, the system will now correctly process paths and identifiers that contain this character, resolving display or parsing issues that could arise from its misinterpretation.

Highlights

  • Regex Update for Separators: The regular expressions used in clean_separators functions across turbopack-browser and turbopack-core crates have been updated to explicitly include the @ symbol as a character to be handled.
  • URL Decoding Prevention: This change prevents unintended URL decoding issues by ensuring the @ symbol is correctly identified and processed as a separator, resolving potential display or parsing problems as illustrated by the 'Before' and 'After' images in the PR description.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 23, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the @ character to the list of separators to be cleaned in two different clean_separators functions. The changes are a good improvement, especially in turbopack-browser/src/chunking_context.rs where the regex logic was also corrected. However, I've noticed a potential inconsistency between the two modified clean_separators functions. The function in turbopack-browser does not clean the characters []<>, while the one in turbopack-core does. I've added a suggestion to align them to prevent potential issues with invalid characters in generated file paths.

@fireairforce fireairforce merged commit e108a89 into utoo Dec 23, 2025
12 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elrrrrrrr elrrrrrrr elrrrrrrr approved these changes

@xusd320 xusd320 xusd320 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fireairforce @elrrrrrrr @xusd320