fix(cat): refine unsafe overwrite detection for appending files #9122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
is_unsafe_overwritefunction to improve logic when appending to files. Previously, the check for zero-sized files was combined with input/output equality, leading to potential false negatives. Now, separate the checks: return false if inputs differ, or if output file is empty. For appending mode, allow safe overwrites if input position is at or beyond file size. This prevents data loss while permitting valid append operations.fix cat-self test