Skip to content

Updated build to be compatible with Go 1.12 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DavidWatkins wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Updated build to be compatible with Go 1.12 #15

DavidWatkins wants to merge 5 commits into from

Conversation

@DavidWatkins
Copy link

@DavidWatkins DavidWatkins commented Mar 9, 2019

I had an issue where I could not build on my Raspberry Pi. I also added instructions for creating a service. Some of my URLs are pointing to my repo. I think the way Go handles imports doesn't lend itself well to pull requests? Let me know how I should proceed.

@step21
Copy link

step21 commented May 28, 2019

Does this NEED go 1.12? Tried it on my raspberry pi 2 with go 1.7 and 1.8. Both give these errors similar to what was reported in another issue.

# github.com/miekg/dns
../go/src/github.com/miekg/dns/dnssec_keyscan.go:260: undefined: strings.Builder
../go/src/github.com/miekg/dns/msg_helpers.go:145: base32.HexEncoding.WithPadding undefined (type *base32.Encoding has no field or method WithPadding)
../go/src/github.com/miekg/dns/msg_helpers.go:145: undefined: base32.NoPadding
../go/src/github.com/miekg/dns/msg_helpers.go:271: undefined: strings.Builder
../go/src/github.com/miekg/dns/serve_mux.go:43: undefined: strings.Builder
../go/src/github.com/miekg/dns/types.go:440: undefined: strings.Builder
../go/src/github.com/miekg/dns/types.go:464: undefined: strings.Builder
../go/src/github.com/miekg/dns/types.go:492: undefined: strings.Builder
../go/src/github.com/miekg/dns/types.go:513: undefined: strings.Builder
../go/src/github.com/miekg/dns/types.go:523: undefined: strings.Builder
../go/src/github.com/miekg/dns/types.go:492: too many errors

The issues of miekg/dns do not seem to have anything about this.

@myzhang1029 myzhang1029 mentioned this pull request Jan 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DavidWatkins @step21