Adding dateCells option #1723
Merged
Adding dateCells option #1723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js/bootstrap-datepicker.js
Outdated
There was a problem hiding this comment.
Looks like that it should be removed. Build is broken in Travis because console object not found.
Member
There was a problem hiding this comment.
Yes any logging/debugging lines should be removed
Contributor
Author
|
Oops! My bad. I'll fix that |
Adds an option to add a data-date attribute with a timestamp representative of THAT CELL’s date. This makes bootstrap-datepicker more extensible when using callbacks. Have not run grunt dist removing console log
Contributor
Author
|
Updated and squashed commits. Looks like it passes the test now. Sorry about that! |
Member
|
Thanks @jpdevries |
Closed
|
Has this option been documented or am I overlooking it in the docs? |
Member
|
It seems that the docs are indeed still missing. Do you want to open a PR with the missing docs @RinkAttendant6? Or can you add the missing docs @jpdevries? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to add a data-date attribute with a timestamp representative of that cell's date. This makes bootstrap-datepicker more extensible when using callbacks.
Have not run
grunt distAdded unit tests as well.
