Skip to content

Refactoring js #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
acrobat merged 1 commit into from
Jun 12, 2016
Merged

Refactoring js #1893

acrobat merged 1 commit into from
Jun 12, 2016

Conversation

@vsn4ik
Copy link
Member

@vsn4ik vsn4ik commented May 14, 2016

No description provided.

acrobat
acrobat reviewed May 25, 2016
View reviewed changes
js/bootstrap-datepicker.js
return parseInt(val) + 1;
});
if (this.o.calendarWeeks) {
this.picker.find('.datepicker-days .datepicker-switch, thead .datepicker-title, tfoot .today, tfoot .clear')
Copy link
Member

@acrobat acrobat May 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the extra classes needed?

Copy link
Member Author

@vsn4ik vsn4ik May 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.datepicker-days?

Copy link
Member Author

@vsn4ik vsn4ik May 25, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding column occurs only in .datepicker-days.

Copy link
Member

@acrobat acrobat May 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the .datepicker-days .datepicker-switch classes. Don't think this is wrong, but just curious why they are added!

Copy link
Member Author

@vsn4ik vsn4ik May 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this. See below: 4c70aca#diff-dd513a8bab7ad1033c8784c4a1b9ce15L828

Copy link
Member

@acrobat acrobat May 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes i see!

@vsn4ik
Copy link
Member Author

vsn4ik commented Jun 12, 2016

I hope not to have to wait another month...

@acrobat acrobat merged commit 8071673 into uxsolutions:master Jun 12, 2016
@acrobat acrobat added this to the 1.7.0 milestone Jun 12, 2016
@vsn4ik
Copy link
Member Author

vsn4ik commented Jun 13, 2016

Thanks!

@vsn4ik vsn4ik deleted the refactoring_js branch June 13, 2016 05:20
@vsn4ik vsn4ik mentioned this pull request Jul 22, 2016
Merged
@acrobat acrobat mentioned this pull request May 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@vsn4ik @acrobat