Hackweek - Add module BV #1961
Hackweek - Add module BV #1961
Conversation
1790d2d to
be1b774
Compare
There was a problem hiding this comment.
Pull request overview
This PR introduces a new build validation (BV) module for Terraform that provides a common template for BV and SLE maintenance update deployments. The module uses parameters defined at the project level to customize deployments, creating a more maintainable and reusable infrastructure-as-code solution.
Key Changes:
- Creates a comprehensive build validation module with 94 configurable variables
- Implements module definitions for 60+ different system configurations (servers, proxies, minions, clients, etc.)
- Supports multiple Linux distributions (SLES, Ubuntu, Debian, Alma, Rocky, CentOS, Oracle, Amazon Linux) across different architectures (x86_64, ARM, s390)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 15 comments.
| File | Description |
|---|---|
| modules/build_validation/variables.tf | Defines 15 input variables for environment configuration, credentials, container images, and base configurations |
| modules/build_validation/main.tf | Implements the main Terraform configuration with provider setup, base modules, and 60+ conditional module instances for various Linux distributions and system roles |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c2ca6a1 to
6e031f9
Compare
|
Can we take advantage of this refactor to introduce names like rh_like or deb_like instead of res and debian? Also I wonder if still make sense the org by old_sle and new_sle, taking into account the amount of VMs on each of them |
Remove comment
6e031f9 to
81671ed
Compare
6d0b694 to
2c9d9eb
Compare
What does this PR change?
Create a build validation module to make a main.tf template common to all BV and sle maintenance update.
Use parameters to modify the deployments.
Those parameters are declared at the susemanager-ci project level.