Skip to content

Conversation

@aragaer
Copy link

@aragaer aragaer commented Oct 17, 2016

This would allow creating a binding like "gl*" to open a link in a new tab.

@mathstuf
Copy link
Member

The REQ_NEW_WINDOW event is meant to be hooked up to the new tab or new window event based on your preferences. I feel like a command to force a new window would be more interesting (since in a tabbed environment, it still makes sense while in a non-tabbed environment, it's just the same thing).

@aragaer
Copy link
Author

aragaer commented Oct 17, 2016

Now that I have found those preferences I no longer actually need this fix. But to make a "force new window" the biggest problem I see is what name it should be. "forcenewwindow"?

@mathstuf
Copy link
Member

It's mostly internal anyway, so that'd work for me.

@keis
Copy link
Member

keis commented Oct 17, 2016

It would be nice if we could have consistency with the event names but unless we're changing 'newwindow' I don't think we can do that. +1 on forcenewwindow

@mathstuf
Copy link
Member

We could add a new alias reqnewwindow for the existing one and deprecate the old one (though I don't know how best to deprecate things in these areas).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants