Skip to content

Conversation

@jhult
Copy link

@jhult jhult commented Aug 28, 2025

Description

Enable CredentialManager APIs for all apps supporting passkeys. I believe this will fix #329.

Original Source: https://github.com/GrapheneOS/Vanadium/blob/2c952098a599ef5ebd2b00012d5f3b254c3d5168/patches/0157-Enable-CredentialManager-APIs-for-all-apps-supportin.patch

I have not built/tested this myself.

All submissions

  • there are no other open Pull Requests for the same update/change
  • Bromite can be built with these changes
  • I have tested that the new change works as intended (AVD or physical device will do)

Format

  • patch subject and filename match (e.g. Subject: Alternative cache (NIK-based) -> Alternative-cache-NIK-based.patch)
  • patch description contains explanation of changes
  • no unnecessary whitespace or unrelated changes

@uazo
Copy link
Owner

uazo commented Aug 29, 2025

@uazo
Copy link
Owner

uazo commented Aug 29, 2025

Thank you! I'll take a look at it.

@jhult
Copy link
Author

jhult commented Aug 30, 2025

@jhult jhult force-pushed the enable-credentialmanager-apis-for-all-apps branch from 911c02d to c581a94 Compare October 7, 2025 14:27
@uazo
Copy link
Owner

uazo commented Oct 9, 2025

I have checked and can confirm that passkey support works even without google APIs, but only with A14+, since credman only supports third-party managers from that version onwards.

What is missing is:

uazo added a commit that referenced this pull request Oct 9, 2025
@uazo
Copy link
Owner

uazo commented Oct 9, 2025

additions made in 6fa2e7b

Thank you for reporting this!

@uazo uazo closed this Oct 9, 2025
@jhult jhult deleted the enable-credentialmanager-apis-for-all-apps branch December 11, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebAuthn does not work

3 participants