4.1.11 and above throws error "tally.internal.counter_cardinality" is not a valid metric name #256

error

I noticed we cannot upgrade past 4.1.10 because we get this error in our tests

panic: descriptor Desc{fqName: "tally.internal.counter_cardinality", help: "tally.internal.counter_cardinality gauge", constLabels: {}, variableLabels: [version host instance]} is invalid: "tally.internal.counter_cardinality" is not a valid metric name [recovered]

I noticed some changes in these tags that may be related

v4.1.10...v4.1.11

Is this panic an expected error or a regression?

references

• https://github.com/runatlantis/atlantis/actions/runs/8496376185/job/23273689226?pr=4228
• https://github.com/runatlantis/atlantis/blob/main/server/metrics/scope.go
• https://github.com/runatlantis/atlantis/blob/84f0fff1696a1f9ef70ba9e5d3f167e8eb4e28e8/server/metrics/scope_test.go#L18
• fix(deps): update module github.com/uber-go/tally/v4 to v4.1.16 in go.mod (main) runatlantis/atlantis#4228 (review)