fix(zapcore): fall back to default Encode* implementations when nil#1551
Open
leno23 wants to merge 1 commit into
Open
fix(zapcore): fall back to default Encode* implementations when nil#1551leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
When EncoderConfig sets LevelKey, TimeKey, or CallerKey but leaves the corresponding encoder function nil, use the same defaults as an empty config instead of failing config.Build or omitting metadata. Fixes uber-go#537 Co-authored-by: Cursor <cursoragent@cursor.com>
|
wuyangfan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EncoderConfigsetsLevelKey,TimeKey, orCallerKeybut leaves the matchingEncode*function nil,newJSONEncodernow applies the same defaults used elsewhere (LowercaseLevelEncoder,EpochTimeEncoder,ShortCallerEncoder)config.Build()failure formissing EncodeTime in EncoderConfig; nil duration encoding already had a runtime fallback viaAppendDurationEncodeLevel/EncodeTime/EncodeDuration/EncodeCallerand for building a config withTimeKeyset but no custom encoderTest plan
go test ./...EncodeTimestill works with"console"encoding (issue repro)Fixes #537