Skip to content

Updating the update cmd to add workspace:* for internal upgrade #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
guspedroso wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updating the update cmd to add workspace:* for internal upgrade #140

guspedroso wants to merge 1 commit into from

Conversation

@guspedroso
Copy link
Collaborator

@guspedroso guspedroso commented May 5, 2023 •
edited
Loading

  • When upgrading internal dependencies, we are using workspace:* instead of the version specified in the package.json for that dependency
  • We are now throwing an error and educating the user on the usage of the jazelle upgrade if they are not including the dependency in the upgrade command
  • The mismatch version error message now shows the correct usage for the jazelle upgrade command

@CLAassistant
Copy link

CLAassistant commented May 5, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@guspedroso guspedroso requested a review from lhorie May 5, 2023 03:50
thegleb
thegleb reviewed May 9, 2023
View reviewed changes
commands/upgrade.js

if (!args.length) {
throw new Error(
'Command must have at least one dependency name. \nUsage: jazelle upgrade [dependency]\n'
Copy link

@thegleb thegleb May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alxmyth
Copy link
Collaborator

alxmyth commented Jun 23, 2023

Discussed briefly during a backlog review meeting. TL;DR- this marries us closer to Yarn, as workspace:* is a Yarn-ism. Not necessarily an issue given Jazelle has been more closely coupled with Yarn over time. Just something to keep in mind.

Otherwise, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alxmyth alxmyth alxmyth approved these changes

@lhorie lhorie Awaiting requested review from lhorie

+1 more reviewer

@thegleb thegleb thegleb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@guspedroso @CLAassistant @alxmyth @thegleb