Skip to content

Add **kwargs to Explainer.plot_shap_values()#603

Merged
jeongyoonlee merged 2 commits into
masterfrom
jeong/fix_601
Mar 16, 2023
Merged

Add **kwargs to Explainer.plot_shap_values()#603
jeongyoonlee merged 2 commits into
masterfrom
jeong/fix_601

Conversation

@jeongyoonlee

Copy link
Copy Markdown
Collaborator

Proposed changes

This PR fixes #601. It adds **kwargs to Explainer.plot_shap_values() so that users can pass additional arguments to shap.summary_plot().

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

N/A

@paullo0106 paullo0106 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeongyoonlee jeongyoonlee merged commit 136e0b6 into master Mar 16, 2023
@jeongyoonlee jeongyoonlee deleted the jeong/fix_601 branch March 16, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make plot_shap_values support **kwargs

2 participants