Skip to content

Precommit#800

Merged
jeongyoonlee merged 10 commits into
uber:masterfrom
spohngellert-o:precommit
Nov 8, 2024
Merged

Precommit#800
jeongyoonlee merged 10 commits into
uber:masterfrom
spohngellert-o:precommit

Conversation

@spohngellert-o
Copy link
Copy Markdown
Contributor

Proposed changes

Adding basic pre-commit hooks. This will make it so that black formatting is run before every commit.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

This isn't exactly a feature, but will allow for more uniform formatting assuming contributors install the pre-commit hooks. I have updated docs to reflect but feel free to suggest any more changes.

Comment thread CONTRIBUTING.md Outdated
@jeongyoonlee jeongyoonlee merged commit a52eef4 into uber:master Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants