Skip to content

Include tvm into the astro tarball#61

Merged
btromanova merged 7 commits into
masterfrom
tr/add-tvm
Jan 16, 2020
Merged

Include tvm into the astro tarball#61
btromanova merged 7 commits into
masterfrom
tr/add-tvm

Conversation

@btromanova

@btromanova btromanova commented Jan 14, 2020

Copy link
Copy Markdown
Contributor

This addresses #58.

Sorry for the duplicate PR, the previous one (#59) was merged to the wrong branch.

Changes:

  • archive -> archives as the latest version of goreleaser only recognize the plural one
  • add tvm to the goreleaser builds (also add build id otherwise it defaults to project_name)
  • add note to readme to say that tvm is included
  • updated changelog

Tested it by pushing tag and running

docker run --rm --privileged -v $PWD:/go/src/github.com/uber/astro -v /var/run/docker.sock:/var/run/docker.sock -w /go/src/github.com/uber/astro -e GITHUB_TOKEN=<> goreleaser/goreleaser  release --rm-dist

I've seen that goreleaser was successful and the tarballs with both astro and tvm were published to github.

@btromanova btromanova requested a review from dansimau January 14, 2020 17:06
Comment thread CHANGELOG.md Outdated
## 0.6.0 (January 15, 2020)

### Added
* Add `tmv` binary to astro release

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: tvm

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dansimau dansimau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix the typo but after that looks good.

@btromanova btromanova merged commit b80aa3d into master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants