Skip to content

Attempt to fix flakey announce test#112

Merged
codygibb merged 1 commit into
masterfrom
codyg/announce-flake
Mar 11, 2019
Merged

Attempt to fix flakey announce test#112
codygibb merged 1 commit into
masterfrom
codyg/announce-flake

Conversation

@codygibb

@codygibb codygibb commented Mar 11, 2019

Copy link
Copy Markdown
Contributor

Fix #111

Give chance for Ticker goroutine to run before waiting for tick.

@codygibb codygibb requested a review from apourchet March 11, 2019 22:07
@codecov-io

codecov-io commented Mar 11, 2019

Copy link
Copy Markdown

Codecov Report

Merging #112 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   67.52%   67.57%   +0.05%     
==========================================
  Files         177      177              
  Lines        8593     8593              
==========================================
+ Hits         5802     5807       +5     
+ Misses       2054     2051       -3     
+ Partials      737      735       -2
Impacted Files Coverage Δ
lib/torrent/scheduler/events.go 69.84% <0%> (+1.5%) ⬆️
utils/dedup/interval_trap.go 100% <0%> (+10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af2ac4d...672d1cd. Read the comment docs.

@apourchet apourchet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codygibb codygibb merged commit 51def02 into master Mar 11, 2019
@yiranwang52 yiranwang52 deleted the codyg/announce-flake branch March 13, 2019 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants