Bump to 4.5.0, add reverseDirectedEdge#207
Open
isaacbrodsky wants to merge 4 commits into
Open
Conversation
Coverage Report for CI Build 637Coverage increased (+0.008%) to 96.962%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Collaborator
Author
|
This job had to be run twice to get a green pass: https://github.com/uber/h3-java/actions/runs/27163934054/job/80188499610 |
dfellis
reviewed
Jun 9, 2026
Comment on lines
+425
to
+444
| assertEquals(actualBounds.get(1).lat, multiBounds.get(0).get(0).get(8).lat, EPSILON); | ||
| assertEquals(actualBounds.get(2).lat, multiBounds.get(0).get(0).get(9).lat, EPSILON); | ||
| assertEquals(actualBounds.get(3).lat, multiBounds.get(0).get(0).get(0).lat, EPSILON); | ||
| assertEquals(actualBounds.get(4).lat, multiBounds.get(0).get(0).get(1).lat, EPSILON); | ||
| assertEquals(actualBounds.get(5).lat, multiBounds.get(0).get(0).get(2).lat, EPSILON); | ||
| assertEquals(actualBounds2.get(4).lat, multiBounds.get(0).get(0).get(3).lat, EPSILON); | ||
| assertEquals(actualBounds2.get(5).lat, multiBounds.get(0).get(0).get(4).lat, EPSILON); | ||
| assertEquals(actualBounds2.get(0).lat, multiBounds.get(0).get(0).get(5).lat, EPSILON); | ||
| assertEquals(actualBounds2.get(1).lat, multiBounds.get(0).get(0).get(6).lat, EPSILON); | ||
| assertEquals(actualBounds2.get(2).lat, multiBounds.get(0).get(0).get(7).lat, EPSILON); | ||
| assertEquals(actualBounds.get(1).lng, multiBounds.get(0).get(0).get(8).lng, EPSILON); | ||
| assertEquals(actualBounds.get(2).lng, multiBounds.get(0).get(0).get(9).lng, EPSILON); | ||
| assertEquals(actualBounds.get(3).lng, multiBounds.get(0).get(0).get(0).lng, EPSILON); | ||
| assertEquals(actualBounds.get(4).lng, multiBounds.get(0).get(0).get(1).lng, EPSILON); | ||
| assertEquals(actualBounds.get(5).lng, multiBounds.get(0).get(0).get(2).lng, EPSILON); | ||
| assertEquals(actualBounds2.get(4).lng, multiBounds.get(0).get(0).get(3).lng, EPSILON); | ||
| assertEquals(actualBounds2.get(5).lng, multiBounds.get(0).get(0).get(4).lng, EPSILON); | ||
| assertEquals(actualBounds2.get(0).lng, multiBounds.get(0).get(0).get(5).lng, EPSILON); | ||
| assertEquals(actualBounds2.get(1).lng, multiBounds.get(0).get(0).get(6).lng, EPSILON); | ||
| assertEquals(actualBounds2.get(2).lng, multiBounds.get(0).get(0).get(7).lng, EPSILON); |
Collaborator
There was a problem hiding this comment.
This is super-brittle. Could we instead confirm that the Set of multiBounds is the same as actualBounds + actualBounds2 instead? Then we won't have to rework this test if there are other changes to how the boundary is calculated.
| assertEquals(actualBounds.size() + 1, multiBounds.get(0).get(0).size()); | ||
|
|
||
| int[] expectedIndices = {0, 1, 2, 3, 4, 5, 0}; | ||
| int[] expectedIndices = {3, 4, 5, 0, 1, 2, 3}; |
Collaborator
There was a problem hiding this comment.
Same nit here: if the order doesn't match the input ordering anymore, we should compare by Set instead of an array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to H3 v4.5.0, adds reverseDirectedEdge, and applies related test fixes.
note: we will need to update these tests: