Skip to content

Set v4 as a released version on the website#635

Merged
isaacbrodsky merged 3 commits into
uber:masterfrom
isaacbrodsky:website-v4-main
Aug 23, 2022
Merged

Set v4 as a released version on the website#635
isaacbrodsky merged 3 commits into
uber:masterfrom
isaacbrodsky:website-v4-main

Conversation

@isaacbrodsky

Copy link
Copy Markdown
Collaborator

Depends on #633.

@coveralls

coveralls commented Aug 3, 2022

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 98.92% when pulling 4d05a06 on isaacbrodsky:website-v4-main into 90748a4 on uber:master.

@dfellis

dfellis commented Aug 3, 2022

Copy link
Copy Markdown
Collaborator

I presume this also depends on the various bindings releasing v4.0.0?

@isaacbrodsky

Copy link
Copy Markdown
Collaborator Author

I presume this also depends on the various bindings releasing v4.0.0?

I think so? Otherwise most of the code samples it would direct users to will not be correct.

@dfellis

dfellis commented Aug 4, 2022

Copy link
Copy Markdown
Collaborator

I presume this also depends on the various bindings releasing v4.0.0?

I think so? Otherwise most of the code samples it would direct users to will not be correct.

It wasn't explicitly called out, so I wasn't sure if I ✔️'ed this PR that it would immediately go out when that's probably not the right thing to do, yet.

@isaacbrodsky

Copy link
Copy Markdown
Collaborator Author

I presume this also depends on the various bindings releasing v4.0.0?

I think so? Otherwise most of the code samples it would direct users to will not be correct.

It wasn't explicitly called out, so I wasn't sure if I ✔️'ed this PR that it would immediately go out when that's probably not the right thing to do, yet.

Yes, the idea is to merge #633 first on August 16, tag & release uber/h3 v4.0.0, update & release binding updates, and then merge this PR. (Releasing binding updates and this PR might be parallelized)

@isaacbrodsky isaacbrodsky merged commit cd87201 into uber:master Aug 23, 2022
@isaacbrodsky isaacbrodsky deleted the website-v4-main branch August 23, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants