fix: handle compacting base cell children#679
Merged
Conversation
isaacbrodsky
reviewed
Sep 8, 2022
Collaborator
|
It looks like around h3Index.c line 344 it tries to take the parent of a res 0 cell at res -1 (res -1 was calculated on line 325), which is where the failure is coming from. |
Contributor
Author
|
I'm uncertain of this solution, but it passes existing tests and the new failing test. Basically if the compaction process reaches a base cell, we skip the parent reserved-bit-hit processing and move on to the rest of the logic. |
isaacbrodsky
reviewed
Sep 8, 2022
isaacbrodsky
reviewed
Sep 8, 2022
isaacbrodsky
reviewed
Sep 8, 2022
isaacbrodsky
approved these changes
Sep 9, 2022
dfellis
approved these changes
Sep 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Children of a res 0 cell should compact back to that cell successfully.