Conversation
|
I'm not sure why it did all this formatting... Any ideas? |
Probably different version of clang-format being used? |
Do we have a standard version I should be using? |
Yes, it is important to use clang-format-14 (until we update the formatter version again) as they change defaults between versions. |
OK. For my future reference, I had to run which feels a bit janky. |
|
I can also make it fail on a different (disjoint from the first example) set of cells with something like int64_t numUncompacted = 44;
t_assertSuccess(
H3_EXPORT(compactCells)(&cells1[80], out, numUncompacted));And I can get this example to pass if I set This is making me wonder if the failure has something to do with how we handle pentagons. |
|
The problem is around line Line 490 in b355c9d parentRes is -1 but we try to take cellToParent of currIndex at parentRes anyways.
|
compactCellscurrently fails when trying to compact all res 1 cells.