Version 3.6.0#273
Merged
Merged
Conversation
…(the PR instead of issue)
nrabinowitz
approved these changes
Aug 12, 2019
nrabinowitz
left a comment
Collaborator
There was a problem hiding this comment.
LG. One question is whether we ought to thank/recognize external contributors in the changelog (some OSS projects do).
dfellis
reviewed
Aug 12, 2019
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [3.5.1] - 2019-08-12 |
Collaborator
There was a problem hiding this comment.
With new features added, shouldn't this be 3.6.0 instead?
Collaborator
Author
There was a problem hiding this comment.
Oops, yes I believe it should.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added changelog entry for #271, and updated the other ones to point to #267 instead of #263 (our changelog entries usually point to the PR rather than the issue)