Skip to content

Version 3.6.0#273

Merged
isaacbrodsky merged 2 commits into
uber:masterfrom
isaacbrodsky:version-3.5.1
Aug 13, 2019
Merged

Version 3.6.0#273
isaacbrodsky merged 2 commits into
uber:masterfrom
isaacbrodsky:version-3.5.1

Conversation

@isaacbrodsky

Copy link
Copy Markdown
Collaborator

Added changelog entry for #271, and updated the other ones to point to #267 instead of #263 (our changelog entries usually point to the PR rather than the issue)

@nrabinowitz nrabinowitz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. One question is whether we ought to thank/recognize external contributors in the changelog (some OSS projects do).

Comment thread CHANGELOG.md Outdated

## [Unreleased]

## [3.5.1] - 2019-08-12

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With new features added, shouldn't this be 3.6.0 instead?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, yes I believe it should.

@isaacbrodsky isaacbrodsky changed the title Version 3.5.1 Version 3.6.0 Aug 12, 2019
@isaacbrodsky isaacbrodsky merged commit 7728307 into uber:master Aug 13, 2019
@isaacbrodsky isaacbrodsky deleted the version-3.5.1 branch August 13, 2019 20:47
mrdvt92 pushed a commit to mrdvt92/h3 that referenced this pull request Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants