Dev ktr neg coef #601
Merged
Dev ktr neg coef #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwinnglabs
requested changes
Oct 14, 2021
Collaborator
edwinnglabs
left a comment
There was a problem hiding this comment.
Is there any simulation / unit test cases we can verify models can directionally detect signs of regressors coef? It may be applicable to other models as well. we can open another issue to generally cover that if that is the case.
Contributor
Author
can you approve this PR? I can add the unit test for this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements the negative coefficient for the ktr model
fixes #585