Skip to content

Conversation

@GavinSteiningerUber
Copy link
Collaborator

Description

This PR is to add BIC for feature selection with the MAP estimator.
Included is a tutorial notebook.

Type of change

  • [ x] New feature

How Has This Been Tested?

standard tests
Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests.

@edwinnglabs edwinnglabs added enhancement Utils and interface enhancement / more flexibility. review needed need someone to review labels Feb 19, 2022
Copy link
Contributor

@wangzhishi wangzhishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangzhishi wangzhishi merged commit 465b600 into dev Feb 25, 2022
@wangzhishi wangzhishi deleted the gavin-bic-map branch February 25, 2022 20:03
Copy link
Collaborator Author

@GavinSteiningerUber GavinSteiningerUber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Utils and interface enhancement / more flexibility. review needed need someone to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants