Skip to content

Conversation

@jeongyoonlee
Copy link
Collaborator

@jeongyoonlee jeongyoonlee commented Jun 27, 2022

Description

Minor code cleanup w/ Python 3 syntax including:

  • remove (object) in class definitions
  • remove from __future__ import absolute_import, division, print_function
  • remove .travis.yml
  • update the Python version in tox.ini to py38
  • ignore F401: imported but unused lint error for __init__.py files

Type of change

Please delete options that are not relevant.

  • Bug fix
  • New feature
  • Breaking change
  • This change requires a documentation update
  • Backend change such as github actions, travisCI etc.

How Has This Been Tested?

All tests have passed without an error.

Copy link
Collaborator

@edwinnglabs edwinnglabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeongyoonlee jeongyoonlee merged commit 5355d6f into dev Jun 27, 2022
@jeongyoonlee jeongyoonlee deleted the jeong/nit-py38-updates branch June 27, 2022 23:03
edwinnglabs added a commit that referenced this pull request Nov 30, 2022
* v1.1.3dev

* add python 3.8/3.9 to workflow (#752)

* add python 3.8 to workflow

* add python 3.9 to workflow

* update

* optimize interface (#755)

* update residual diagnostic plots and example notebook (#758)

* update residual diagnostic plots and example notebook

* minor fix on unused import

* diagnostic

* Create residual_diagnostic.ipynb

* temp

* update

* notebook update

* Update plot.py

* Update plot.py

* Update plot.py

* update

* fix bug

* update plot function

* Update plot.py

* Update model_diagnostics.ipynb

* remove file

* fixing lint problem

* refreshing diagnostic notebook

* Update plot.py

* Update residual_diagnostic.ipynb

Co-authored-by: Edwin Ng <edwinnglabs@gmail.com>

* Fix tqdm outlook (#762)

* init proposal

This should fix the tqdm outlook and slightly adjust the arg to make forecast and its child consistent.

* Update hyper_parameters_tuning.ipynb

* init proposal

This should fix the tqdm outlook and slightly adjust the arg to make forecast and its child consistent.

* Update hyper_parameters_tuning.ipynb

* a message added for ipywidgets

* lint fix

* Dev requirements fix (#763)

* torch version update

* release process update

* minor code cleanup w/ Python 3 syntax (#765)

* Edwin/some utils (#769)

* Update stan.py

* lint

* Dev fix ktr (#771)

* fix re-instantiation bug in KTR

* tutorial update

* fix re-instantiation bug in KTR

* tutorial update

* Add new utils (#778)

* temp

* adding new utils

* Update general.py

* Bug fix/numpy freeze (#783)

* Update requirements.txt

* Update build.yaml

* Update build.yaml

* Update build.yaml

* Update build.yaml

* Update ktr1.ipynb (#777)

* Update ktr1.ipynb

* Update ktr1.ipynb

* global trend prior enhancement (#786)

* global trend prior enhancement

* lint reformatting

* notebook refresh

notebook refresh

Co-authored-by: Zhishi Wang <zhishiw@uber.com>
Co-authored-by: Zhishi Wang <wangzhishi@users.noreply.github.com>
Co-authored-by: Ariel Jiang <ariel.jiang@uber.com>
Co-authored-by: Jeong-Yoon Lee <jeongyoon.lee1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants