Skip to content

upgrade pyro config #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
edwinnglabs merged 2 commits into from
Nov 6, 2020
Merged

upgrade pyro config #270

edwinnglabs merged 2 commits into from
Nov 6, 2020

Conversation

@edwinnglabs
Copy link
Collaborator

@edwinnglabs edwinnglabs commented Nov 6, 2020

Description

Enhance Pyro Optimization Config with learning_rate_decay and num_particles

Fixes # #269

  • New feature
  • This change requires a documentation update

See

  1. this for num_particles
  2. this for learning_rate_decay

@edwinnglabs edwinnglabs added new idea / feature request New feature or request review needed need someone to review labels Nov 6, 2020
wangzhishi
wangzhishi approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@wangzhishi wangzhishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edwinnglabs edwinnglabs merged commit a9facad into master Nov 6, 2020
@edwinnglabs edwinnglabs deleted the pyro-config-upgrade branch November 25, 2020 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vincewu51 vincewu51 Awaiting requested review from vincewu51

1 more reviewer

@wangzhishi wangzhishi wangzhishi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

new idea / feature request New feature or request review needed need someone to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edwinnglabs @wangzhishi