Update README.md #370
Merged
Update README.md #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relative paths for contribution docs
|
|
Collaborator
|
I was doing full path due to deployment on PyPI (the README will be directly duplicate there) and assuming the README file eventually merge with master (hence the master path)..in fact we could do a dev branch path as well. |
edwinnglabs
approved these changes
Feb 24, 2021
Contributor
Author
|
Thank you so much! |
edwinnglabs
pushed a commit
that referenced
this pull request
Feb 27, 2021
* Update README.md relative paths for contribution docs * change link to dev Co-authored-by: Zhishi Wang <zhishiw@uber.com>
edwinnglabs
pushed a commit
that referenced
this pull request
Feb 27, 2021
* Update README.md relative paths for contribution docs * change link to dev Co-authored-by: Zhishi Wang <zhishiw@uber.com>
edwinnglabs
pushed a commit
that referenced
this pull request
Mar 3, 2021
* add changelogs * fix conflict * Some documentation change (#367) * Update README.md * Create orbit-banner640x320.png * Update RELEASE.md * Update setup.py * updating a few admin docs - code of conduct - contributing - release * Update README.md * Update README.md * Update README.md (#370) * Update README.md relative paths for contribution docs * change link to dev Co-authored-by: Zhishi Wang <zhishiw@uber.com> * rebase and refine of docs * rebasE * Some documentation change (#367) * Update README.md * Create orbit-banner640x320.png * Update RELEASE.md * Update setup.py * updating a few admin docs - code of conduct - contributing - release * Update README.md * Update README.md * Update README.md (#370) * Update README.md relative paths for contribution docs * change link to dev Co-authored-by: Zhishi Wang <zhishiw@uber.com> * Update README.md * Some documentation change (#367) * Update README.md * Create orbit-banner640x320.png * Update RELEASE.md * Update setup.py * updating a few admin docs - code of conduct - contributing - release * Update README.md * Update README.md * rebase and refine of docs * rebasE Co-authored-by: Edwin Ng <edwinng@uber.com> Co-authored-by: Chi Po Choi <cpchoi@ucdavis.edu> Co-authored-by: Zhishi Wang <zhishiw@uber.com>
vincewu51
pushed a commit
that referenced
this pull request
Mar 24, 2021
* Update README.md relative paths for contribution docs * change link to dev Co-authored-by: Zhishi Wang <zhishiw@uber.com>
vincewu51
pushed a commit
that referenced
this pull request
Mar 24, 2021
* add changelogs * fix conflict * Some documentation change (#367) * Update README.md * Create orbit-banner640x320.png * Update RELEASE.md * Update setup.py * updating a few admin docs - code of conduct - contributing - release * Update README.md * Update README.md * Update README.md (#370) * Update README.md relative paths for contribution docs * change link to dev Co-authored-by: Zhishi Wang <zhishiw@uber.com> * rebase and refine of docs * rebasE * Some documentation change (#367) * Update README.md * Create orbit-banner640x320.png * Update RELEASE.md * Update setup.py * updating a few admin docs - code of conduct - contributing - release * Update README.md * Update README.md * Update README.md (#370) * Update README.md relative paths for contribution docs * change link to dev Co-authored-by: Zhishi Wang <zhishiw@uber.com> * Update README.md * Some documentation change (#367) * Update README.md * Create orbit-banner640x320.png * Update RELEASE.md * Update setup.py * updating a few admin docs - code of conduct - contributing - release * Update README.md * Update README.md * rebase and refine of docs * rebasE Co-authored-by: Edwin Ng <edwinng@uber.com> Co-authored-by: Chi Po Choi <cpchoi@ucdavis.edu> Co-authored-by: Zhishi Wang <zhishiw@uber.com>
edwinnglabs
pushed a commit
that referenced
this pull request
Mar 27, 2021
* Update README.md relative paths for contribution docs * change link to dev Co-authored-by: Zhishi Wang <zhishiw@uber.com>
edwinnglabs
pushed a commit
that referenced
this pull request
Mar 27, 2021
* add changelogs * fix conflict * Some documentation change (#367) * Update README.md * Create orbit-banner640x320.png * Update RELEASE.md * Update setup.py * updating a few admin docs - code of conduct - contributing - release * Update README.md * Update README.md * Update README.md (#370) * Update README.md relative paths for contribution docs * change link to dev Co-authored-by: Zhishi Wang <zhishiw@uber.com> * rebase and refine of docs * rebasE * Some documentation change (#367) * Update README.md * Create orbit-banner640x320.png * Update RELEASE.md * Update setup.py * updating a few admin docs - code of conduct - contributing - release * Update README.md * Update README.md * Update README.md (#370) * Update README.md relative paths for contribution docs * change link to dev Co-authored-by: Zhishi Wang <zhishiw@uber.com> * Update README.md * Some documentation change (#367) * Update README.md * Create orbit-banner640x320.png * Update RELEASE.md * Update setup.py * updating a few admin docs - code of conduct - contributing - release * Update README.md * Update README.md * rebase and refine of docs * rebasE Co-authored-by: Edwin Ng <edwinng@uber.com> Co-authored-by: Chi Po Choi <cpchoi@ucdavis.edu> Co-authored-by: Zhishi Wang <zhishiw@uber.com>
wangzhishi
added a commit
that referenced
this pull request
Apr 2, 2021
* Update README.md relative paths for contribution docs * change link to dev Co-authored-by: Zhishi Wang <zhishiw@uber.com>
wangzhishi
added a commit
that referenced
this pull request
Apr 2, 2021
* add changelogs * fix conflict * Some documentation change (#367) * Update README.md * Create orbit-banner640x320.png * Update RELEASE.md * Update setup.py * updating a few admin docs - code of conduct - contributing - release * Update README.md * Update README.md * Update README.md (#370) * Update README.md relative paths for contribution docs * change link to dev Co-authored-by: Zhishi Wang <zhishiw@uber.com> * rebase and refine of docs * rebasE * Some documentation change (#367) * Update README.md * Create orbit-banner640x320.png * Update RELEASE.md * Update setup.py * updating a few admin docs - code of conduct - contributing - release * Update README.md * Update README.md * Update README.md (#370) * Update README.md relative paths for contribution docs * change link to dev Co-authored-by: Zhishi Wang <zhishiw@uber.com> * Update README.md * Some documentation change (#367) * Update README.md * Create orbit-banner640x320.png * Update RELEASE.md * Update setup.py * updating a few admin docs - code of conduct - contributing - release * Update README.md * Update README.md * rebase and refine of docs * rebasE Co-authored-by: Edwin Ng <edwinng@uber.com> Co-authored-by: Chi Po Choi <cpchoi@ucdavis.edu> Co-authored-by: Zhishi Wang <zhishiw@uber.com>
wangzhishi
added a commit
that referenced
this pull request
Apr 2, 2021
This reverts commit 3e6c43e.
wangzhishi
added a commit
that referenced
this pull request
Apr 2, 2021
* Update README.md relative paths for contribution docs * change link to dev Co-authored-by: Zhishi Wang <zhishiw@uber.com>
wangzhishi
added a commit
that referenced
this pull request
Apr 2, 2021
* add changelogs * fix conflict * Some documentation change (#367) * Update README.md * Create orbit-banner640x320.png * Update RELEASE.md * Update setup.py * updating a few admin docs - code of conduct - contributing - release * Update README.md * Update README.md * Update README.md (#370) * Update README.md relative paths for contribution docs * change link to dev Co-authored-by: Zhishi Wang <zhishiw@uber.com> * rebase and refine of docs * rebasE * Some documentation change (#367) * Update README.md * Create orbit-banner640x320.png * Update RELEASE.md * Update setup.py * updating a few admin docs - code of conduct - contributing - release * Update README.md * Update README.md * Update README.md (#370) * Update README.md relative paths for contribution docs * change link to dev Co-authored-by: Zhishi Wang <zhishiw@uber.com> * Update README.md * Some documentation change (#367) * Update README.md * Create orbit-banner640x320.png * Update RELEASE.md * Update setup.py * updating a few admin docs - code of conduct - contributing - release * Update README.md * Update README.md * rebase and refine of docs * rebasE Co-authored-by: Edwin Ng <edwinng@uber.com> Co-authored-by: Chi Po Choi <cpchoi@ucdavis.edu> Co-authored-by: Zhishi Wang <zhishiw@uber.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relative paths for contribution docs
Description
The links of code of conduct and contributing guidelines are in absolute path
https://github.com/uber/orbit/blob/master/which does not contain the docs.The links should be relative paths so that the links work in GitHub
README.mdhomepage in every branch.I replaced them with relative paths as described in GitHub Docs About READMEs.
Type of change
How Has This Been Tested?
Created a branch with the relative links and push it into GitHub. Went to the README.md homepage and click the links! For example, my branch for the pull request pochoi-contr-links.