Skip to content

Conversation

@wangzhishi
Copy link
Contributor

remove the dependency on package scikit-learn by adding an internal function yield_param_grid in diagnostics/backtest.py.

@wangzhishi wangzhishi requested a review from a team March 12, 2021 03:49
Copy link
Collaborator

@edwinnglabs edwinnglabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangzhishi wangzhishi added the deprecation Deprecate a feature label Mar 12, 2021
Copy link
Collaborator

@edwinnglabs edwinnglabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wangzhishi wangzhishi merged commit 7b776e0 into dev Mar 12, 2021
@wangzhishi wangzhishi deleted the remove_sklearn branch March 12, 2021 06:36
vincewu51 pushed a commit that referenced this pull request Mar 24, 2021
* internal function yield_param_grid

* remove the dependency on scikit-learn

* use orbit.utils.simulation to simulate data

* delete unused utils folder in orbit/tests

* simulation data update

* pytest fixture

* column reordering

* StanEstimatorVI
edwinnglabs pushed a commit that referenced this pull request Mar 27, 2021
* internal function yield_param_grid

* remove the dependency on scikit-learn

* use orbit.utils.simulation to simulate data

* delete unused utils folder in orbit/tests

* simulation data update

* pytest fixture

* column reordering

* StanEstimatorVI
wangzhishi added a commit that referenced this pull request Apr 2, 2021
* internal function yield_param_grid

* remove the dependency on scikit-learn

* use orbit.utils.simulation to simulate data

* delete unused utils folder in orbit/tests

* simulation data update

* pytest fixture

* column reordering

* StanEstimatorVI
wangzhishi added a commit that referenced this pull request Apr 2, 2021
wangzhishi added a commit that referenced this pull request Apr 2, 2021
* internal function yield_param_grid

* remove the dependency on scikit-learn

* use orbit.utils.simulation to simulate data

* delete unused utils folder in orbit/tests

* simulation data update

* pytest fixture

* column reordering

* StanEstimatorVI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Deprecate a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants