Skip to content

Conversation

@edwinnglabs
Copy link
Collaborator

@edwinnglabs edwinnglabs commented Mar 19, 2021

Description

Since we have more families of models, we need to refactor base template to capture the core functions of building abstract model. This aims to set up much quicker process to build a new Bayesian model.

Fix

Fixes #382
Fixes #385
Fixes #386

@edwinnglabs edwinnglabs added the WIP Someone is aware of this and working in progress label Mar 19, 2021
@edwinnglabs edwinnglabs requested a review from a team March 19, 2021 05:54
@edwinnglabs edwinnglabs changed the title initial commit for refactoring Refactoring of Templates, Fixing Labels with and w/o prefix "_", Fixing bugs in Initial Values of Sampling Mar 19, 2021
@edwinnglabs edwinnglabs added refactor Issues to remove tech debt or improve design review needed need someone to review and removed WIP Someone is aware of this and working in progress labels Mar 19, 2021
Copy link
Contributor

@wangzhishi wangzhishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edwinnglabs edwinnglabs merged commit fd5e0c6 into dev Mar 20, 2021
@edwinnglabs edwinnglabs deleted the feat-refactor-template branch March 20, 2021 00:41
vincewu51 pushed a commit that referenced this pull request Mar 24, 2021
…ng bugs in Initial Values of Sampling (#384)

* initial commit for refactoring

* relabel dlt parameters

* relabel ktrlite

* Update ktrlite.ipynb

* Update ktrlite.py

* attribute renaming

* attribute renaming

* tutorial updates

Co-authored-by: Zhishi Wang <zhishiw@uber.com>
edwinnglabs pushed a commit that referenced this pull request Mar 27, 2021
…ng bugs in Initial Values of Sampling (#384)

* initial commit for refactoring

* relabel dlt parameters

* relabel ktrlite

* Update ktrlite.ipynb

* Update ktrlite.py

* attribute renaming

* attribute renaming

* tutorial updates

Co-authored-by: Zhishi Wang <zhishiw@uber.com>
wangzhishi added a commit that referenced this pull request Apr 2, 2021
…ng bugs in Initial Values of Sampling (#384)

* initial commit for refactoring

* relabel dlt parameters

* relabel ktrlite

* Update ktrlite.ipynb

* Update ktrlite.py

* attribute renaming

* attribute renaming

* tutorial updates

Co-authored-by: Zhishi Wang <zhishiw@uber.com>
wangzhishi added a commit that referenced this pull request Apr 2, 2021
…_", Fixing bugs in Initial Values of Sampling (#384)"

This reverts commit 40cff8f.
wangzhishi added a commit that referenced this pull request Apr 2, 2021
…ng bugs in Initial Values of Sampling (#384)

* initial commit for refactoring

* relabel dlt parameters

* relabel ktrlite

* Update ktrlite.ipynb

* Update ktrlite.py

* attribute renaming

* attribute renaming

* tutorial updates

Co-authored-by: Zhishi Wang <zhishiw@uber.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Issues to remove tech debt or improve design review needed need someone to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Initial Values Callable Bug Relabel fields between with and w/o prefix "_" Refactor for Base Template

3 participants