-
Notifications
You must be signed in to change notification settings - Fork 141
Refactoring of Templates, Fixing Labels with and w/o prefix "_", Fixing bugs in Initial Values of Sampling #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangzhishi
approved these changes
Mar 19, 2021
Contributor
wangzhishi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vincewu51
pushed a commit
that referenced
this pull request
Mar 24, 2021
…ng bugs in Initial Values of Sampling (#384) * initial commit for refactoring * relabel dlt parameters * relabel ktrlite * Update ktrlite.ipynb * Update ktrlite.py * attribute renaming * attribute renaming * tutorial updates Co-authored-by: Zhishi Wang <zhishiw@uber.com>
edwinnglabs
pushed a commit
that referenced
this pull request
Mar 27, 2021
…ng bugs in Initial Values of Sampling (#384) * initial commit for refactoring * relabel dlt parameters * relabel ktrlite * Update ktrlite.ipynb * Update ktrlite.py * attribute renaming * attribute renaming * tutorial updates Co-authored-by: Zhishi Wang <zhishiw@uber.com>
wangzhishi
added a commit
that referenced
this pull request
Apr 2, 2021
…ng bugs in Initial Values of Sampling (#384) * initial commit for refactoring * relabel dlt parameters * relabel ktrlite * Update ktrlite.ipynb * Update ktrlite.py * attribute renaming * attribute renaming * tutorial updates Co-authored-by: Zhishi Wang <zhishiw@uber.com>
wangzhishi
added a commit
that referenced
this pull request
Apr 2, 2021
…ng bugs in Initial Values of Sampling (#384) * initial commit for refactoring * relabel dlt parameters * relabel ktrlite * Update ktrlite.ipynb * Update ktrlite.py * attribute renaming * attribute renaming * tutorial updates Co-authored-by: Zhishi Wang <zhishiw@uber.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we have more families of models, we need to refactor base template to capture the core functions of building abstract model. This aims to set up much quicker process to build a new Bayesian model.
Fix
Fixes #382
Fixes #385
Fixes #386