Skip to content

Conversation

@edwinnglabs
Copy link
Collaborator

Description

Refine template further more where overriding _set_dynamic_attributes() is easier.

@edwinnglabs edwinnglabs added refactor Issues to remove tech debt or improve design tutorial labels Mar 22, 2021
@edwinnglabs edwinnglabs requested a review from a team March 22, 2021 19:41
@edwinnglabs edwinnglabs self-assigned this Mar 22, 2021
@edwinnglabs edwinnglabs changed the title Feat refine template Refine Template - refine set dynamic attributes Mar 22, 2021
Copy link
Contributor

@wangzhishi wangzhishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edwinnglabs edwinnglabs merged commit 2a96753 into dev Mar 23, 2021
@edwinnglabs edwinnglabs deleted the feat-refine-template branch March 23, 2021 01:22
wangzhishi added a commit that referenced this pull request Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Issues to remove tech debt or improve design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants