propagate props for discrete color legend#998
Merged
mcnuttandrew merged 3 commits intoOct 9, 2018
Conversation
Contributor
|
@Wattenberger You continue to do wonderful things! You get 1 Million Stamps of Approval |
ayarcohaila
pushed a commit
to ayarcohaila/react-vis
that referenced
this pull request
Jun 30, 2021
* propagate props for discrete color legend * added test to check that discrete color legend is retaining styles * remove accidentally committed line in legend tests
ayarcohaila
added a commit
to ayarcohaila/react-vis
that referenced
this pull request
May 30, 2023
* propagate props for discrete color legend * added test to check that discrete color legend is retaining styles * remove accidentally committed line in legend tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #893
This should retain any
styles passed to DiscreteColorLegendI updated the example so the styles actually change the legend position, and didn't forget a test this time 🙌