Feat/enable CI for local main branch#140
Merged
Merged
Conversation
75a31b2 to
b923793
Compare
m0nhawk
approved these changes
Jun 11, 2024
b923793 to
f01e0f0
Compare
Author
|
hm...seems most tests are now actually failing with likely because of some dependency update, maybe here 06067d5 |
|
I think it's because of this: Lines 832 to 834 in 06067d5 And this was introduced in 2.9.0: https://javadoc.io/doc/commons-io/commons-io/2.9.0/org/apache/commons/io/IOUtils.html#byteArray-- |
Author
|
@m0nhawk nice catch, although this line has been there for the last 3 years.... so I still think it is a side effect of another update, since the tests pass on upstream |
b5261b3 to
c8c7e83
Compare
Author
|
done...now I get another error: looks like we need 2.14.0 |
99962b3 to
a43248a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/VADC-1102
Improvements