Skip to content

Ensure all GPIO signals are tied off #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jerryz123 merged 1 commit into from
Feb 16, 2024
Merged

Ensure all GPIO signals are tied off #1732

jerryz123 merged 1 commit into from
Feb 16, 2024

Conversation

@tymcauley
Copy link
Contributor

@tymcauley tymcauley commented Jan 8, 2024

Related PRs / Issues:

Resolves #1731.

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@tymcauley tymcauley force-pushed the gpio-undriven-signals branch from d3fe97e to 777c76a Compare January 8, 2024 00:06
@T-K-233 T-K-233 requested review from T-K-233 and jerryz123 January 14, 2024 07:19
T-K-233
T-K-233 approved these changes Jan 14, 2024
View reviewed changes
Copy link
Member

@T-K-233 T-K-233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good.
Thanks!

jerryz123
jerryz123 requested changes Jan 14, 2024
View reviewed changes
Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, but before we do, the PR to rocket-chip-blocks must be merged.

@tymcauley tymcauley force-pushed the gpio-undriven-signals branch from 777c76a to 392ab4f Compare February 15, 2024 18:14
@tymcauley
Copy link
Contributor Author

tymcauley commented Feb 15, 2024

Okay, finally got that rocket-chip-blocks PR merged, thanks @jerryz123. Not sure if the rocket-chip-blocks bump is pulling in more changes than desired now, or if this is okay.

@jerryz123
Copy link
Contributor

jerryz123 commented Feb 15, 2024

This is good, thanks!

@jerryz123
Copy link
Contributor

jerryz123 commented Feb 15, 2024

Ok odd... this broke SPI flash.. I don't think this is related to your changes... but warrants some investigation

@tymcauley
Copy link
Contributor Author

tymcauley commented Feb 15, 2024

Ok odd... this broke SPI flash.. I don't think this is related to your changes... but warrants some investigation

I guess this is the first time that this PR is getting pulled into Chipyard, which does touch the SPI controller: chipsalliance/rocket-chip-blocks#25

@jerryz123
Copy link
Contributor

jerryz123 commented Feb 16, 2024

Thanks for chasing down the commit. I've reverted it on rocket-chip-blocks

@tymcauley tymcauley force-pushed the gpio-undriven-signals branch from 392ab4f to 0a922a0 Compare February 16, 2024 03:58
@tymcauley tymcauley force-pushed the gpio-undriven-signals branch from 0a922a0 to 262469e Compare February 16, 2024 04:00
@tymcauley
Copy link
Contributor Author

tymcauley commented Feb 16, 2024

Thanks for chasing down the commit. I've reverted it on rocket-chip-blocks

np! I've merged that change into here, hopefully CI is all fixed now.

@jerryz123 jerryz123 merged commit 53c6e8a into ucb-bar:main Feb 16, 2024
@tymcauley tymcauley deleted the gpio-undriven-signals branch February 16, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerryz123 jerryz123 jerryz123 approved these changes

@T-K-233 T-K-233 T-K-233 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error generating Verilog for GPIORocketConfig, undriven signals in GPIO

3 participants

@tymcauley @jerryz123 @T-K-233