Clear completion state when preedit changes#118
Open
PKxk8J wants to merge 1 commit into
Open
Conversation
072f816 to
13ba944
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tab completion keeps using the previous completion iterator after the
preedit is edited. This can show the next candidate for the old reading
instead of recomputing candidates for the current reading.
Reproducer:
Expected:
Completion is recomputed from the current preedit.
Actual:
Completion continues from the previous candidate list.
This patch clears cached completion state when normal/abbrev preedit is
edited, while preserving repeated Tab cycling when the preedit is unchanged.
Tests added for deletion, normal preedit editing, and abbrev editing.