features: library and examples. Introducing ruby 3.4 support #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razvand
requested changes
Dec 12, 2025
Contributor
razvand
left a comment
There was a problem hiding this comment.
Use your proper name in author and signed-off information. Replace adriannv with Adrian Guzun or Adrian-Vasile Guzun.
Contributor
|
Make this a full PR. Work is done from your point of view. |
e9b097c to
795ced5
Compare
Author
Done, updated author info on the commits and marked it ready for review |
razvand
requested changes
Dec 13, 2025
Contributor
razvand
left a comment
There was a problem hiding this comment.
You are missing a colon (:) in one of the commits.
Contributor
|
For me, using |
Author
I did need 512 for running locally, i must've forgotten to specify that in all of the README's. |
795ced5 to
ab004d7
Compare
razvand
requested changes
Dec 13, 2025
Signed-off-by: Adrian-Vasile Guzun <guzunadrian.vasile@gmail.com>
Signed-off-by: Adrian-Vasile Guzun <guzunadrian.vasile@gmail.com>
Signed-off-by: Adrian-Vasile Guzun <guzunadrian.vasile@gmail.com>
ab004d7 to
1eb27c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added library/ruby 3.4. whats different is when running a local build of 3.4 we now need 512mb instead of 256mb from back in 3.2 to avoid errors.
Added examples for https server in native unikraft and a base based example