Skip to content

feat(fontless): transform with lightningcss when enabled by vite #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielroe merged 2 commits into from
Sep 10, 2025
Merged

feat(fontless): transform with lightningcss when enabled by vite #626

danielroe merged 2 commits into from
Sep 10, 2025

Conversation

@danielroe
Copy link
Member

@danielroe danielroe commented Sep 10, 2025

resolves #602

@danielroe danielroe self-assigned this Sep 10, 2025
@netlify
Copy link

netlify bot commented Sep 10, 2025 •
edited
Loading

✅ Deploy Preview for fontless ready!

Name Link
🔨 Latest commit e0bb178
🔍 Latest deploy log https://app.netlify.com/projects/fontless/deploys/68c17951cd32550009302983
😎 Deploy Preview https://deploy-preview-626--fontless.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Sep 10, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 40.74074% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.59%. Comparing base (d89e67c) to head (e0bb178).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/fontless/src/utils.ts 55.00% 9 Missing ⚠️
packages/fontless/src/vite.ts 0.00% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
+ Coverage   53.30%   53.59%   +0.29%     
==========================================
  Files          11       11              
  Lines         636      653      +17     
  Branches       86       89       +3     
==========================================
+ Hits          339      350      +11     
- Misses        297      303       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielroe danielroe merged commit d72ed16 into main Sep 10, 2025
7 of 8 checks passed
@danielroe danielroe deleted the feat/lightningcss branch September 10, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheAlexLichter TheAlexLichter TheAlexLichter approved these changes

Assignees

@danielroe danielroe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider Lightning CSS for transformation

3 participants

@danielroe @TheAlexLichter