You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would wish pkg-pr-new handles it automatically instead of us patching it
I'm talking with @Aslemammad, this is a temporary patch here... maybe we can add some utility since we need to provide the packages globs to pkg-pr-new to patch the packages before publishing
The problem is about ignoring the package.json file when running pnpm pack, it is not being used and pkg-pr-new should merge the package.json dependencies with the generated by the pack command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
read-yaml-fileinsteadyaml=> it is small, check them at pgk-size:@jacob-8 @Aslemammad
Check screenshot here #4397 (comment) versus: