fix(ci): mozc rebase で廃止された update_deps.py の --nosubmodules フラグを除去#5
Merged
Merged
Conversation
mozc の upstream rebase 後、update_deps.py から --nosubmodules フラグが 削除されており、PR #1 の CI (Update Mozc dependencies ステップ) が exit 2 で3連続失敗していた。CI workflow とビルドスクリプトから除去。 (run-ci-build.bat は未追跡のためローカルのみ修正) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Fixes CI failures introduced after the Mozc upstream rebase by removing the now-deleted --nosubmodules flag from all call sites of build_tools/update_deps.py. This aligns the repository’s Windows build scripts and GitHub Actions workflows with Mozc’s current dependency update script interface.
Changes:
- Remove
--nosubmodulesfromupdate_deps.pyinvocations in GitHub Actions workflows (x64/arm64). - Remove
--nosubmodulesfromupdate_deps.pyinvocations in local Windows build scripts (x64/arm64).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build-x64.bat | Drops deprecated --nosubmodules from dependency update calls used during x64 build flow. |
| build-arm64.bat | Drops deprecated --nosubmodules from dependency update call used during ARM64 build flow. |
| .github/workflows/build-x64.yml | Updates CI dependency update step to remove --nosubmodules so Build x64 no longer fails on argument parsing. |
| .github/workflows/build-arm64.yml | Updates CI dependency update step to remove --nosubmodules so Build arm64 matches current Mozc script args. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
PR #1 の CI (
Build x64) が PR #2 マージ以降3連続失敗していた件の修正。原因
mozc の upstream rebase（PR #2）で
build_tools/update_deps.pyから--nosubmodulesフラグが削除されたが、CI workflow とビルドスクリプトが旧引数のまま渡しており、Update Mozc dependenciesステップが exit 2 で失敗していた。ローカル検証では bazelisk を直接叩いていたため update_deps.py の引数誤りを検出できなかった（反省点）。
変更
.github/workflows/build-x64.yml/build-arm64.yml:--nosubmodulesを除去build-x64.bat（2箇所）/build-arm64.bat: 同上現行の有効引数は
--noninja --noqt --nollvm --nomsys2 --nowix --nondk --cache_only。検証
この PR の CI（PR #1 への synchronize で走る Build x64）が該当ステップを通過することで検証される。
🤖 Generated with Claude Code