fix: add back types/* subpackages exports
#418
Merged
+93
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
commit: |
5 tasks
Member
Author
|
@antfu with latest changes (last commit) this is breaking since we don't need |
Member
Author
|
arggg, pkg-pr-new failing, will require a dummy commit (already published, the link should be fine, some pkg-pr-new internal thingy 😄 , it is a new error) |
antfu
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DON'T MERGE YET: I need to review default package exports via
require(webpack), and maybe update the readme.md file here.NOTE: with latest changes (af4ac3e commit) this is breaking since we don't need
.defaultwhen requiring, I can revertnodechanges if you want (remove the tsdownbuild:donehook and thepatchNode16CJSDefaultExportshelper function). If keeping breaking change, I need to update the readme.md and do some tests (maybe we can export some additional subpackage export to fix the default export having also the types, I can add them here => webpack, rspack, for example and some others unplugin subpackages exports without types, but can use./types🤔 )NOTE: node changes reverted, it should be fine to release a patch version to fix missing
types/*.This PR also fixes
node16CJS types (for.and./resolver), exporting default and types, includednamespacehack, I need to check it (also fixed node 10 module resolutions for.(just patching them for node16 CJS) andtypes/*subpackage exports):closes #417