Skip to content

DX-1996: print warning if error in custom auth #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CahidArda merged 2 commits into from
Jul 25, 2025
Merged

DX-1996: print warning if error in custom auth #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dc8432
fix: add warning if auth check fails b/c of error
CahidArda Jul 24, 2025
bdecc3c
feat: add warning if auth checks receives an error
CahidArda Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/context/steps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,10 @@ export class LazyWaitForEventStep<TEventData> extends BaseLazyStep<WaitStepRespo
};
}

public async getResultStep(concurrent: number, stepId: number): Promise<Step<WaitStepResponse<TEventData>>> {
public async getResultStep(
concurrent: number,
stepId: number
): Promise<Step<WaitStepResponse<TEventData>>> {
return await Promise.resolve({
stepId,
stepName: this.stepName,
Expand Down
3 changes: 3 additions & 0 deletions src/serve/authorization.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ export class DisabledWorkflowContext<
) {
return ok("step-found");
}
console.warn(
"Upstash Workflow: Received an error while authorizing request. Please avoid throwing errors before the first step of your workflow."
);
return err(error as Error);
}

Expand Down
Loading