Return 400 on auth failure #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| new Response(JSON.stringify({ workflowRunId }), { | ||
| onStepFinish: (workflowRunId: string, finishCondition: FinishCondition) => { | ||
| if (finishCondition === "auth-fail") { | ||
| console.error(AUTH_FAIL_MESSAGE); |
Contributor
There was a problem hiding this comment.
Maybe we can log with debug?.log
Collaborator
Author
There was a problem hiding this comment.
How about we have both? If we only have debug, then the user won't understand what's happening if they get this error uninentionally
Collaborator
Author
There was a problem hiding this comment.
debug.log is async. onStepFinish would have to be async. it's a breaking change. I think we should do it later.
joschan21
reviewed
Nov 29, 2024
|
|
||
| await qstash.checkWorkflowStart(messageId) | ||
| try { | ||
| await qstash.checkWorkflowStart(messageId); |
Contributor
There was a problem hiding this comment.
what about the case shouldWorkflowStart is false, but the workflow starts?
Collaborator
Author
There was a problem hiding this comment.
I did check this case today, and realised that checkWorkflowStart doesn't work as I expect at all :D
I will remove it altogether in #32 after we merge this. I didn't want to cause conflicts.
fahreddinozcan
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now return
status: 400in response to auth failures. The text of the message reads:The caveat is being updated with upstash/docs#336. See the preview
Also did the following in the CI: