vere: support long-form command line arguments#5428
Merged
Conversation
Uses getopts_long to support long-form versions of every existing command line argument, and adds them all to the help text, adding some missing entries along the way.
Tested by building vere and trying it with `-B`, `-p`, and `-F`.
vere: alphabetize getopt short options
joemfb
approved these changes
Feb 2, 2022
joemfb
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for doing this, @Fang-!
In the long run, I'm not sure that we want to enforce the variant that all short options have long options. There's more than a couple short options that are just gestures towards features that need to be (re-)implemented. And I'd like to make a pass over some of these names. But I haven't been able to get to those things, and this is much better than what we currently have.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
getopts_longto support long-form versions of every existingcommand line argument, and adds them all to the help text, adding some
missing entries along the way.
This frees us from the confines of the alphabet, giving us the breathing room we need to move forward confidently.
I just off-the-cuff'd most of these, feel free to suggest alternatives etc.