Skip to content

mesa: handle multi jumbo-frame pages#7361

Merged
pkova merged 13 commits into
developfrom
yu/cleanup-jumbo-pokes
Jun 11, 2026
Merged

mesa: handle multi jumbo-frame pages#7361
pkova merged 13 commits into
developfrom
yu/cleanup-jumbo-pokes

Conversation

@yosoyubik

@yosoyubik yosoyubik commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

WIP

Option a)

The sender blocks any %poke %plea/ %poke %boon that tries to send a %page that doesn't fit in 1 jumbo (boq=31) frame.

  • confirm no other reentrant [%ames %done] can use ev-clean
    • seems safe (also for %boons)
  • make +fo-clean use the actual seq number? (XX not in the wire)
    • XX this could be a problem is the send-window becomes > 1
  • refactor +co-make-pact to distinguish legitimate multi-jumbo %pokes, rather than any generic "we can't make this pact now"
  • give a real error:ames
  • the %boon is dropped and the subscriber %kicked (i.e. enqueues a %kick to be sent instead of the original %boon (equivalent to the %clog machinery)
    • at the point where we know this goes over the number of jumbo frames we can handle (e.g. 1 if boq 31), the %clog id has been lost

Option b)

  • Instead og blocking the sender, nack when the receiver gets a poke with bytes > jumbo-max.
    • XX problem for %boons since those are assumed to always be acked
    • we crash while handling the %boon, then %give %lost to %gall to %leave the subscription

TODO

  • implement option b)

@yosoyubik yosoyubik force-pushed the yu/cleanup-jumbo-pokes branch from 1f3fc20 to e96976b Compare June 9, 2026 12:31
@yosoyubik yosoyubik changed the title mesa: give poke-ack error if page bigger than jumbo-frame mesa: handle multi jumbo-frame pages Jun 10, 2026
@pkova pkova marked this pull request as ready for review June 11, 2026 11:58
@pkova pkova merged commit 5ddb0ab into develop Jun 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants