build: fetch urcrypt instead of vendoring it#524
Merged
Conversation
5793177 to
a3d3c2f
Compare
a3d3c2f to
849cdc3
Compare
Merged
Collaborator
|
@matthew-levan I seem to recall there being some question about the urcrypt header pattern here; has that been resolved? if so, feel free to merge. |
Contributor
Author
Yea there were, but I never got around to resolving them. Looks like the build is working though in CI-- should we just merge and punt on the header particulars? |
Collaborator
|
This fails on my machine: |
Contributor
Author
|
Ok, I don't get that error on my Mac. Which system are you using? Do you
have `/usr/local/include/urcrypt.h` installed? Which command produced that
stack trace? Thanks.
…On Mon, Nov 13, 2023 at 11:39 AM Joe Bryan ***@***.***> wrote:
This fails on my machine:
Makefile.am: installing 'build-aux/depcomp'
Makefile.am:23: error: 'pkgconfig_DATA' is used but 'pkgconfigdir' is undefined
autoreconf: error: automake failed with exit status: 1
—
Reply to this email directly, view it on GitHub
<#524 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV2DQRB7DRBD36XCVI23KBTYEJEL5AVCNFSM6AAAAAA5ISE2PWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBYGUZDIOBQGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Collaborator
|
I don't have a |
Contributor
Author
|
Ok, thanks. Which version of macOS and which hardware?
…On Mon, Nov 13, 2023 at 12:07 PM Joe Bryan ***@***.***> wrote:
I don't have a /usr/local/include directory. I checked out your branch
and ran bazel build --clang_version=14.0.0 :urbit.
—
Reply to this email directly, view it on GitHub
<#524 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV2DQRBZJGANNYAHP2VOMDTYEJHVBAVCNFSM6AAAAAA5ISE2PWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBYGYYDAOBQHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Collaborator
|
MacOS 12.6.1. 2021 Macbook Pro (m1 max) |
Contributor
Author
|
Maybe you have to install `pkg-config`. Do you have
`/usr/local/lib/pkgconfig` or `/usr/lib/pkgconfig`?
…On Mon, Nov 13, 2023 at 1:05 PM Joe Bryan ***@***.***> wrote:
MacOS 12.6.1. 2021 Macbook Pro (m1 max)
—
Reply to this email directly, view it on GitHub
<#524 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV2DQRGCGWPSMEVCTKRJLKLYEJOOXAVCNFSM6AAAAAA5ISE2PWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBYG4ZDKMZRGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Collaborator
|
After installing pkg-config via homebrew, i get a new error: |
Contributor
Author
|
Strange. Will try to look later. Are you planning to upgrade your Mac?
Perhaps that might fix it.
…On Wed, Nov 15, 2023 at 9:41 AM Joe Bryan ***@***.***> wrote:
After installing pkg-config via homebrew, i get a new error:
libtool: compile: /usr/bin/clang -DHAVE_CONFIG_H -I. -I/private/var/tmp/_bazel_joemfb/f46182e3eb1bf4d7eff53357bd650651/sandbox/darwin-sandbox/3/execroot/__main__/external/aes_siv -I/private/var/tmp/_bazel_joemfb/f46182e3eb1bf4d7eff53357bd650651/sandbox/darwin-sandbox/3/execroot/__main__/bazel-out/darwin_arm64-opt/bin/external/aes_siv -I/private/var/tmp/_bazel_joemfb/f46182e3eb1bf4d7eff53357bd650651/sandbox/darwin-sandbox/3/execroot/__main__/bazel-out/darwin_arm64-opt/bin/external/openssl/openssl/include -I/private/var/tmp/_bazel_joemfb/f46182e3eb1bf4d7eff53357bd650651/sandbox/darwin-sandbox/3/execroot/__main__/bazel-out/darwin_arm64-opt/bin/external/urcrypt/urcrypt.ext_build_deps/openssl/include -I/private/var/tmp/_bazel_joemfb/f46182e3eb1bf4d7eff53357bd650651/sandbox/darwin-sandbox/3/execroot/__main__/bazel-out/darwin_arm64-opt/bin/external/urcrypt/urcrypt.ext_build_deps/secp256k1/include -march=native -std=c11 -Wextra -Wpedantic -Wall -Wall -g -O3 -MT keccak-tiny/libkeccak_tiny_la-keccak-tiny.lo -MD -MP -MF keccak-tiny/.deps/libkeccak_tiny_la-keccak-tiny.Tpo -c keccak-tiny/keccak-tiny.c -o keccak-tiny/libkeccak_tiny_la-keccak-tiny.o
clang: error: the clang compiler does not support '-march=native'
make[1]: *** [keccak-tiny/libkeccak_tiny_la-keccak-tiny.lo] Error 1
—
Reply to this email directly, view it on GitHub
<#524 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV2DQRBWI7LBLVYABAMRSDLYETIB5AVCNFSM6AAAAAA5ISE2PWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJSGY3DGMRRG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Collaborator
|
This now works on my machine, but is broken on linux in CI. Also, can you update INSTALL.md to mention the new pkg-config dependency for macos? |
e7ba4f2 to
cf391f7
Compare
Contributor
Author
|
Ok I fixed the build, and it should work with compilers that don't support |
Collaborator
|
After this update, the build failed with After i installed autoconf-archive from homebrew, it builds correctly. |
joemfb
requested changes
Nov 15, 2023
cf391f7 to
17e57e0
Compare
joemfb
added a commit
that referenced
this pull request
Jan 25, 2024
See urbit/urbit#6802 and urbit/urcrypt#8 Depends on #524
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As
urcryptnow has its own repository, we can stop vendoring it and simply fetch it like any of our other third-party dependencies.