Skip to content

vere: adds melt, rewrites meld for efficiency#632

Merged
pkova merged 22 commits into
developfrom
jb/melt
May 19, 2025
Merged

vere: adds melt, rewrites meld for efficiency#632
pkova merged 22 commits into
developfrom
jb/melt

Conversation

@joemfb

@joemfb joemfb commented Apr 11, 2024

Copy link
Copy Markdown
Collaborator

This PR adds melt, an on-loom variant of meld originally implemented by @ngzax. The original commits have been cherry-picked into this repo, and the implementation has been touched up to work with current vere. This branch works correctly on a fake ship, more testing is needed.

@joemfb

joemfb commented May 16, 2025

Copy link
Copy Markdown
Collaborator Author

This branch now contains new, simpler versions of melt and meld, implemented on top of verstable.h without unifying equality (and bypassing our implementation issues there).

@joemfb joemfb marked this pull request as ready for review May 16, 2025 14:21
@joemfb joemfb requested a review from a team as a code owner May 16, 2025 14:21
@joemfb joemfb changed the title vere: adds melt, on-loom meld vere: adds melt, rewrites meld for efficiency May 16, 2025
@midden-fabler

Copy link
Copy Markdown
Contributor

worked on my ship:
live: mapped: GB/6.155.796.480
urbit: meld: gained: GB/2.928.519.968

live: mapped: GB/3.227.271.168

@pkova pkova merged commit abee94d into develop May 19, 2025
2 checks passed
@pkova pkova deleted the jb/melt branch May 19, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants