Skip to content

Revert "ames: add libnatpmp for automatic port forwarding"#644

Merged
pkova merged 1 commit into
developfrom
revert-593-pkova/natpmp
May 1, 2024
Merged

Revert "ames: add libnatpmp for automatic port forwarding"#644
pkova merged 1 commit into
developfrom
revert-593-pkova/natpmp

Conversation

@pkova

@pkova pkova commented May 1, 2024

Copy link
Copy Markdown
Collaborator

Reverts #593

This is very likely what is breaking urbit/urbit CI.

@pkova pkova requested a review from a team as a code owner May 1, 2024 18:55
@pkova pkova merged commit c305c50 into develop May 1, 2024
@pkova pkova deleted the revert-593-pkova/natpmp branch May 1, 2024 18:57
pkova added a commit that referenced this pull request Jun 24, 2024
This is #593 that got reverted in #644 because it broke `urbit/urbit`
CI. This PR fixes the issue which was unconditionally calling
`uv_poll_init` on a socket that was initialized with `initnatpmp`
without checking if `initnatpmp` returned an error first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant