Revert "nock: lose subject in autocons more eagerly"#830
Conversation
|
I also got a segfault after the upgrade which dissapeared after running meld. I dismissed it, thinking it was an OOM error |
|
I reproduced it now: booting with this vere, then trying to boot with vere prior to reversal returned |
|
apparently just packing is also enough |
|
u3m_pack is sufficient, u3m_reclaim is necessary |
|
I think I understand now: bytecode caches contain code emitted prior to the update, which was emitted under different assumptions about execution. so the PR must've also included upgrade logic. my bad |
|
Something resembling my |
|
maybe we should have migration test in CI to catch these kinds of bugs? I thought they were already present |
Reverts #827
This PR causes an instant segfault in the serf after upgrading on
~dinleb-rambep,~norsyr-torrynand probably all pre-existing ships. The segfault has the following stacktrace:@quodss @joemfb